Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update porting.h to fix build errors on MacOS 14 / Xcode 15 #14106

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Update porting.h to fix build errors on MacOS 14 / Xcode 15 #14106

merged 1 commit into from
Dec 16, 2023

Conversation

superfloh247
Copy link
Contributor

@superfloh247 superfloh247 commented Dec 15, 2023 •
edited
Loading

error:

../minetest/src/porting.h:266:6: error: 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGETOS]
  266 |         #if TARGET_OS_MAC
      |             ^
../minetest/src/porting.h:268:8: error: 'TARGET_OS_IPHONE' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGETOS]
  268 |         #elif TARGET_OS_IPHONE
      |               ^

@superfloh247 superfloh247 changed the title Update porting.h to build errors on MacOS 14 / Xcode 15 Update porting.h to fix build errors on MacOS 14 / Xcode 15 Dec 15, 2023
@sfan5 sfan5 added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug labels Dec 15, 2023
@sfan5
Copy link
Collaborator

sfan5 commented Dec 15, 2023

Ah, this is my fault and our CI did not catch this.

@wsor4035 wsor4035 added the macOS label Dec 16, 2023
@sfan5 sfan5 merged commit 16c2247 into luanti-org:master Dec 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug macOS Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@superfloh247 @sfan5 @wsor4035