Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rendertarget size being saved as screensize #13313

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Fix rendertarget size being saved as screensize #13313

merged 2 commits into from
Mar 12, 2023

Conversation

Desour
Copy link
Member

@Desour Desour commented Mar 12, 2023

Fixes a regression introduced by #12367.

RenderingEngine::getWindowSize() takes side-by-side into account, so it's not the window size.

cc @rubenwardy

To do

This PR is a Ready for Review.

How to test

  • Set 3d mode to side-by-side.
  • Start a game.
  • Exit to OS.
  • Start minetest again. -> In master the window width is half of before.

@Desour Desour requested a review from rubenwardy March 12, 2023 16:47
@rubenwardy rubenwardy added this to the 5.7.0 milestone Mar 12, 2023
@rubenwardy rubenwardy added @ Client / Audiovisuals Bugfix 🐛 PRs that fix a bug Regression Something that used to work no longer does labels Mar 12, 2023
sfan5
sfan5 reviewed Mar 12, 2023
View reviewed changes
src/client/game.cpp Outdated Show resolved Hide resolved
sfan5
sfan5 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Collaborator

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Desour Desour merged commit 0234681 into luanti-org:master Mar 12, 2023
@Desour Desour deleted the fix_autosave_ss_3d_sidebyside branch March 12, 2023 18:57
appgurueu pushed a commit to appgurueu/minetest that referenced this pull request May 2, 2023
@Desour @appgurueu
Fix rendertarget size being saved as screensize (luanti-org#13313)
7cbfabc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@rubenwardy rubenwardy rubenwardy approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Client / Audiovisuals Regression Something that used to work no longer does >= Two approvals ✅ ✅
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Desour @sfan5 @rubenwardy