-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend bone override capabilities #10704
Conversation
I'm just curious. What is the use case for scaling a bone? |
Boob slider =] Among other things, it's good for FX. And just because, hell, do you need a reason? It's called freedom. You can scale whole objects so why not bones? @appgurueu |
A value of |
That's kinda hacky. Why not property=false/nil? Also, there are more possible spaces than absolute/relative (to what?), maybe that should be a string param on the lua side and an enum on the engine side, to allow further extension. Check this out: |
Properties default to what I have mentioned above. If you pass
Yeah |
Oh, so nil is already handled like that. Well, I like this. |
How does this interact with #10705? Does setting an all-nil override make @theviper121 's function redundant? |
Yes, although it doesn't delete the override if doing so (could implement tho). Instead it justs sets all (0,0,0)-relative overrides (which equals no override). |
Well uh, I'm thoroughly confused but let me just describe the best possible API:
Can you do that? |
Latest commit makes #10705 obsolete
Yes. Currently it only supports Currently, there only are:
I plan to add:
|
Closing as WIP with no progress |
* `set_bone_override(bone, override)` | ||
* `bone`: string | ||
* `override`: `{ position = property, rotation = property, scale = property }` | ||
* `property`: `{ x = 0, y = 0, z = 0, interpolation = 0 --[[in seconds]], absolute = false}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be renamed to interpolation_duration
Revival of this is at #12388 |
Description
Implements bone overrides supporting position, rotation and scale, all of which can be relative and interpolated.
To do
set_bone_position
andget_bone_position
How to test
Use the new documented API.