Apply suggestions from code review

Co-authored-by: SmallJoker <[email protected]>

doc/lua_api.txt

@@ -6727,7 +6727,7 @@ object you are working with still exists.
     object.
 * `set_detach()`
 * `set_bone_position([bone, position, rotation])`
-	* Shorthand for `set_bone_override(bone, {position = {x = position.x, y = position.y, z = position.z, absolute = true}, rotation = {x = rotation.x, y = rotation.y, z = rotation.z, absolute = true}})`
+	* Shorthand for `set_bone_override(bone, {position = ..., rotation = ...})` using absolute values.
 	* Supports older servers & clients (< 5.6)
 	* **Deprecated**, use `set_bone_override` instead
 * `get_bone_position(bone)`: returns position and rotation of the bone

src/script/lua_api/l_object.cpp

@@ -572,7 +572,7 @@ int ObjectRef::l_set_bone_override(lua_State *L)
 	if (!lua_isnil(L, 2))
 		bone = readParam<std::string>(L, 2);
 	BoneOverride *override = new BoneOverride();
-	if (lua_isnil(L, 3) || lua_isnone(L, 3)) {
+	if (lua_isnoneornil(L, 3)) {
 		sao->setBoneOverride(bone, override);
 		return 0;
 	}

src/server/unit_sao.cpp

@@ -293,9 +293,9 @@ std::string UnitSAO::generateUpdateBonePositionCommand(
 	writeF32(os, override->rotation.interpolation_duration);
 	writeF32(os, override->scale.interpolation_duration);
 	// clang-format off
-	writeU8(os, override->position.absolute * 1
-	          + override->rotation.absolute * 2
-	          + override->scale.absolute    * 4);
+	writeU8(os, (override->position.absolute & 1) << 0
+	          | (override->rotation.absolute & 1) << 1
+	          | (override->scale.absolute & 1) << 2);
 	// clang-format on
 	return os.str();
 }

src/server/unit_sao.h

@@ -59,8 +59,7 @@ class UnitSAO : public ServerActiveObject
 	// Bone position
 	void setBoneOverride(const std::string &bone, BoneOverride *override);
 	BoneOverride *getBoneOverride(const std::string &bone);
-	const std::unordered_map<std::string, BoneOverride*> &
-	getBoneOverrides() const;
+	const std::unordered_map<std::string, BoneOverride*> &getBoneOverrides() const;
 
 	// Attachments
 	ServerActiveObject *getParent() const;