Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic method to get attribute values from LDAP #32

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Generic method to get attribute values from LDAP #32

merged 1 commit into from
Sep 18, 2024

Conversation

abpai94
Copy link
Contributor

@abpai94 abpai94 commented Aug 26, 2024 •
edited
Loading

#31

@coudot coudot linked an issue Aug 26, 2024 that may be closed by this pull request
Make generic Ldap::get_password_attribute to Ldap::get_attribute_value function #31
Closed
coudot
coudot requested changes Aug 26, 2024
View reviewed changes
phpunit.xml Outdated Show resolved Hide resolved
src/Ltb/Ldap.php Outdated Show resolved Hide resolved
@coudot coudot added the enhancement New feature or request label Aug 26, 2024
@coudot coudot added this to the 0.3.0 milestone Aug 26, 2024
@coudot
Copy link
Member

coudot commented Aug 26, 2024

We should also add a unit test in tests/Ltb/LdapTest.php

@davidcoutadeur davidcoutadeur self-requested a review August 26, 2024 17:30
@davidcoutadeur
Copy link

I'll give a look to this feature on tomorrow.

@abpai94 : if the feature is finished, could your 1/ squash your commits and 2/ rebase on top of master? Thanks

davidcoutadeur
davidcoutadeur requested changes Aug 27, 2024
View reviewed changes
Copy link

@davidcoutadeur davidcoutadeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.

Last thing: we need to add the unit test for the new get_attribute_values function.

You can give a look to function test_get_password_value in file tests/Ltb/LdapTest.php

@abpai94 abpai94 force-pushed the 31-generic-ldap-get-values branch from ded66fd to 0b2e433 Compare September 18, 2024 10:01
@abpai94
Copy link
Contributor Author

abpai94 commented Sep 18, 2024

@davidcoutadeur tests added, ready to merge!

@abpai94 abpai94 force-pushed the 31-generic-ldap-get-values branch from 1ad645d to 6a036cd Compare September 18, 2024 14:35
@davidcoutadeur davidcoutadeur merged commit 177c85a into ltb-project:main Sep 18, 2024
1 check passed
@davidcoutadeur davidcoutadeur deleted the 31-generic-ldap-get-values branch September 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coudot coudot coudot approved these changes

@davidcoutadeur davidcoutadeur davidcoutadeur approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Make generic Ldap::get_password_attribute to Ldap::get_attribute_value function
3 participants
@abpai94 @coudot @davidcoutadeur