Tests for OpenLDAP

ltb-project · Nov 19, 2024 · 42f74e1 · 42f74e1
1 parent 4523948
commit 42f74e1
Show file tree

Hide file tree

Showing 2 changed files with 133 additions and 4 deletions.
diff --git a/src/Ltb/Directory/OpenLDAP.php b/src/Ltb/Directory/OpenLDAP.php
@@ -335,15 +335,15 @@ public function isAccountValid($ldap, $dn) : bool {
 
         $time = time();
 
-        if ( $entry[0]['pwdstarttime'] ) {
-            $startdate = \Ltb\Date::adDate2phpDate($entry[0]['pwdstarttime'][0]);
+        if ( isset($entry[0]['pwdstarttime']) ) {
+            $startdate = \Ltb\Date::ldapDate2phpDate($entry[0]['pwdstarttime'][0]);
             if ( $time <= $startdate->getTimestamp() ) {
                 return false;
             }
         }
 
-        if ( $entry[0]['pwdstarttime'] ) {
-            $enddate = \Ltb\Date::adDate2phpDate($entry[0]['pwdendtime'][0]);
+        if ( isset($entry[0]['pwdendtime']) ) {
+            $enddate = \Ltb\Date::ldapDate2phpDate($entry[0]['pwdendtime'][0]);
             if ( $time >= $enddate->getTimestamp() ) {
                 return false;
             }

diff --git a/tests/Ltb/DirectoryTest.php b/tests/Ltb/DirectoryTest.php
@@ -351,6 +351,135 @@ public function test_openldap_reset_false_empty(): void
         $this->assertFalse($reset, "Reset should be false");
     }
 
+    public function test_openldap_isvalid_nodate(): void
+    {
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 0,
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\OpenLDAP)->isAccountValid(null, null);
+        $this->assertTrue($isAccountValid, "Account should be valid");
+    }
+
+    public function test_openldap_isvalid_startdate_before(): void
+    {
+        $dt = new DateTime;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'pwdstarttime' => [
+                        'count' => 1,
+                        0 => $dt->modify("-1 week")->format("Ymdhis\Z"),
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\OpenLDAP)->isAccountValid(null, null);
+        $this->assertTrue($isAccountValid, "Account should be valid");
+    }
+
+    public function test_openldap_isvalid_startdate_after(): void
+    {
+        $dt = new DateTime;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'pwdstarttime' => [
+                        'count' => 1,
+                        0 => $dt->modify("+1 week")->format("Ymdhis\Z"),
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\OpenLDAP)->isAccountValid(null, null);
+        $this->assertFalse($isAccountValid, "Account should not be valid");
+    }
+
+    public function test_openldap_isvalid_enddate_before(): void
+    {
+        $dt = new DateTime;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'pwdendtime' => [
+                        'count' => 1,
+                        0 => $dt->modify("-1 week")->format("Ymdhis\Z"),
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\OpenLDAP)->isAccountValid(null, null);
+        $this->assertFalse($isAccountValid, "Account should not be valid");
+    }
+
+    public function test_openldap_isvalid_enddate_after(): void
+    {
+        $dt = new DateTime;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'pwdendtime' => [
+                        'count' => 1,
+                        0 => $dt->modify("+1 week")->format("Ymdhis\Z"),
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\OpenLDAP)->isAccountValid(null, null);
+        $this->assertTrue($isAccountValid, "Account should be valid");
+    }
+
+    public function test_openldap_isvalid_bothdate(): void
+    {
+        $dt = new DateTime;
+        $phpLDAPMock = Mockery::mock('overload:Ltb\PhpLDAP');
+        $phpLDAPMock->shouldreceive([
+            'ldap_read' => null,
+            'ldap_errno' => 0,
+            'ldap_get_entries' => [
+                'count' => 1,
+                0 => [
+                    'pwdstarttime' => [
+                        'count' => 1,
+                        0 => $dt->modify("-1 week")->format("Ymdhis\Z"),
+                    ],
+                    'pwdendtime' => [
+                        'count' => 1,
+                        0 => $dt->modify("+2 week")->format("Ymdhis\Z"),
+                    ]
+                ]
+            ]
+        ]);
+
+        $isAccountValid = (new Ltb\Directory\OpenLDAP)->isAccountValid(null, null);
+        $this->assertTrue($isAccountValid, "Account should be valid");
+    }
+
     public function test_activedirectory_islocked_locked_forever(): void
     {
         $ad_date = ((int)time() + 11644473600) * 10000000;