DM-33478: Use type hinting when converting to PropertySet #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a large slowdown in PropertySet creation if
PropertySet.set()
is called without a type being specified. The Configs know the types of their fields so use those types explicitly.Problematically, the integer type must still be guessed and therefore should either reimplement the guessing code (without the
isinstance
check because we know it's anint
and we know the field doesn't exist) or callps.set()
explicitly -- this defeats the entire purpose of the optimization. Problematicallyps.getAsInt()
raises when getting a small integer from a long long entry in the container. Rewriting the C++ code to useps.getAsInt64()
could work but is likely not worth it (there are about 15 calls to fix).