-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-48788: Use ruff format #116
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 86.01% 86.09% +0.07%
==========================================
Files 46 46
Lines 3648 3647 -1
==========================================
+ Hits 3138 3140 +2
+ Misses 510 507 -3 ☔ View full report in Codecov by Sentry. |
Found by bugbear
@ktlim I had a go at fixing some Bugbear warnings. Would you mind taking a quick look at the three commits (raises, zip, unused variables)? Bugbear is complaining about one more problem (used 5 times): python/lsst/pex/config/listField.py:344:42: B004 [*] Using `hasattr(x, "__call__")` to test if x is callable is unreliable. Use `callable(x)` for consistent results.
|
342 | if listCheck is not None and not hasattr(listCheck, "__call__"):
343 | raise ValueError("'listCheck' must be callable")
344 | if itemCheck is not None and not hasattr(itemCheck, "__call__"):
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ B004
345 | raise ValueError("'itemCheck' must be callable")
|
= help: Replace with `callable()` which seems fine but I see that the docs for |
Checklist
doc/changes