Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onnx] Relax constraints on input tensors in onnx.STFT conversion to torch dialect #3676

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[onnx] Relax constraints on input tensors in onnx.STFT conversion to torch dialect #3676

merged 3 commits into from
Sep 23, 2024

Conversation

giacs-epic
Copy link
Contributor

  • When the signal tensor is real, onnx allows its shape to be [batch][length] as well as [batch][length][1].
  • Onnx also allows to specify frame_length together with window (not empty), given that it matches the window size.
  • Adding checks on signal and result shapes.

@vivekkhandelwal1 vivekkhandelwal1 merged commit 9984826 into llvm:main Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekkhandelwal1 vivekkhandelwal1 vivekkhandelwal1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giacs-epic @vivekkhandelwal1