Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] Add test for CWG203 "Type of address-of-member expression" #121687

Merged
merged 5 commits into from
Jan 6, 2025
Merged

[clang] Add test for CWG203 "Type of address-of-member expression" #121687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bca2bfe
[clang] Add test for CWG203 "Type of address-of-member expression"
Endilll Jan 5, 2025
fcda3b2
Fix expected directives
Endilll Jan 5, 2025
4ee9469
Bump availability to 3.0, because 2.9 crashes
Endilll Jan 6, 2025
438d3eb
Rename `main` functions to something else
Endilll Jan 6, 2025
d3d6d1b
Merge remote-tracking branch 'upstream/main' into cwg203
Endilll Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 138 additions & 3 deletions clang/test/CXX/drs/cwg2xx.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// RUN: %clang_cc1 -std=c++11 %s -verify=expected,since-cxx11,cxx98-11,cxx98-14,cxx98-17 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++14 %s -verify=expected,since-cxx11,since-cxx14,cxx98-14,cxx98-17 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++17 %s -verify=expected,since-cxx11,since-cxx14,since-cxx17,cxx98-17 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++20 %s -verify=expected,since-cxx11,since-cxx14,since-cxx17 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++23 %s -verify=expected,since-cxx11,since-cxx14,since-cxx17 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++2c %s -verify=expected,since-cxx11,since-cxx14,since-cxx17 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++20 %s -verify=expected,since-cxx11,since-cxx14,since-cxx17,since-cxx20 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++23 %s -verify=expected,since-cxx11,since-cxx14,since-cxx17,since-cxx20 -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++2c %s -verify=expected,since-cxx11,since-cxx14,since-cxx17,since-cxx20 -fexceptions -fcxx-exceptions -pedantic-errors

// FIXME: diagnostic above is emitted only on Windows platforms
// PR13819 -- __SIZE_TYPE__ is incompatible.
Expand Down Expand Up @@ -42,6 +42,141 @@ namespace cwg202 { // cwg202: 3.1
template struct X<f>;
} // namespace cwg202

namespace cwg203 { // cwg203: 3.0
namespace ex1 {
struct B {
int i;
};
struct D1 : B {};
struct D2 : B {};

int(D1::*pmD1) = &D2::i;
} // namespace ex1

#if __cplusplus >= 202002L
namespace ex2 {
struct A {
int i;
virtual void f() = 0; // #cwg203-ex2-A-f
};

struct B : A {
int j;
constexpr B() : j(5) {}
virtual void f();
};

struct C : B {
constexpr C() { j = 10; }
};

template <class T>
constexpr int DefaultValue(int(T::*m)) {
return T().*m;
// since-cxx20-error@-1 {{allocating an object of abstract class type 'cwg203::ex2::A'}}
// since-cxx20-note@#cwg203-ex2-a {{in instantiation of function template specialization 'cwg203::ex2::DefaultValue<cwg203::ex2::A>' requested here}}
// since-cxx20-note@#cwg203-ex2-A-f {{unimplemented pure virtual method 'f' in 'A'}}
} // #cwg203-ex2-DefaultValue

int a = DefaultValue(&B::i); // #cwg203-ex2-a
static_assert(DefaultValue(&C::j) == 5, "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static_assert(DefaultValue(&C::j) == 5, "");
static_assert(DefaultValue(&C::j) == 5);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are only 10 cases of C++17-style static_assert through C++ DR tests, so I'd like to remain consistent.

} // namespace ex2
#endif

namespace ex3 {
class Base {
public:
int func() const;
};

class Derived : public Base {};

template <class T> class Templ { // #cwg203-ex3-Templ
public:
template <class S> Templ(S (T::*ptmf)() const); // #cwg203-ex3-Templ-ctor
};

void foo() { Templ<Derived> x(&Derived::func); }
// expected-error@-1 {{no matching constructor for initialization of 'Templ<Derived>'}}
// expected-note@#cwg203-ex3-Templ {{candidate constructor (the implicit copy constructor) not viable: no known conversion from 'int (cwg203::ex3::Base::*)() const' to 'const Templ<Derived>' for 1st argument}}
// since-cxx11-note@#cwg203-ex3-Templ {{candidate constructor (the implicit move constructor) not viable: no known conversion from 'int (cwg203::ex3::Base::*)() const' to 'Templ<Derived>' for 1st argument}}
// expected-note@#cwg203-ex3-Templ-ctor {{candidate template ignored: could not match 'cwg203::ex3::Derived' against 'cwg203::ex3::Base'}}
} // namespace ex3

namespace ex4 {
struct Very_base {
int a;
};
struct Base1 : Very_base {};
struct Base2 : Very_base {};
struct Derived : Base1, Base2 {
};

int f() {
Derived d;
// FIXME: in the diagnostic below, Very_base is fully qualified, but Derived is not
int Derived::*a_ptr = &Derived::Base1::a;
/* expected-error@-1
{{ambiguous conversion from pointer to member of base class 'cwg203::ex4::Very_base' to pointer to member of derived class 'Derived':
struct cwg203::ex4::Derived -> Base1 -> Very_base
struct cwg203::ex4::Derived -> Base2 -> Very_base}}*/
}
} // namespace ex4

namespace ex5 {
struct Base {
int a;
};
struct Derived : Base {
int b;
};

template <typename Class, typename Member_type, Member_type Base::*ptr>
Member_type get(Class &c) {
return c.*ptr;
}

void call(int (*f)(Derived &)); // #cwg203-ex5-call

int f() {
// ill-formed, contrary to Core issue filing:
// `&Derived::b` yields `int Derived::*`, which can't initialize NTTP of type `int Base::*`,
// because (implicit) pointer-to-member conversion doesn't upcast.
call(&get<Derived, int, &Derived::b>);
// expected-error@-1 {{no matching function for call to 'call'}}
// expected-note@#cwg203-ex5-call {{candidate function not viable: no overload of 'get' matching 'int (*)(Derived &)' for 1st argument}}

// well-formed, contrary to Core issue filing:
// `&Derived::a` yields `int Base::*`,
// which can initialize NTTP of type `int Base::*`.
call(&get<Derived, int, &Derived::a>);

call(&get<Base, int, &Derived::a>);
// expected-error@-1 {{no matching function for call to 'call'}}
// expected-note@#cwg203-ex5-call {{candidate function not viable: no overload of 'get' matching 'int (*)(Derived &)' for 1st argument}}
}
} // namespace ex5

namespace ex6 {
struct Base {
int a;
};
struct Derived : private Base { // #cwg203-ex6-Derived
public:
using Base::a; // make `a` accessible
};

int f() {
Derived d;
int b = d.a;
// FIXME: in the diagnostic below, Base is fully qualified, but Derived is not
int Derived::*ptr = &Derived::a;
// expected-error@-1 {{cannot cast private base class 'cwg203::ex6::Base' to 'Derived'}}
// expected-note@#cwg203-ex6-Derived {{declared private here}}
}
} // namespace ex6
} // namespace cwg203

// cwg204: sup 820

namespace cwg206 { // cwg206: 2.7
Expand Down
2 changes: 1 addition & 1 deletion clang/www/cxx_dr_status.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,7 +1263,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2>
<td><a href="https://cplusplus.github.io/CWG/issues/203.html">203</a></td>
<td>NAD</td>
<td>Type of address-of-member expression</td>
<td class="unknown" align="center">Unknown</td>
<td class="full" align="center">Clang 3.0</td>
</tr>
<tr id="204">
<td><a href="https://cplusplus.github.io/CWG/issues/204.html">204</a></td>
Expand Down
Loading