Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] LowerXMR: process all modules #8168

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

youngar
Copy link
Member

@youngar youngar commented Feb 1, 2025

This changes LowerXMR to process all modules instead of just those that are reachable from the top level module.

@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Feb 1, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llvm Outdated Show resolved Hide resolved
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the fix!

This changes LowerXMR to process all modules instead of just those that
are reachable from the top level module.
@youngar youngar merged commit d070590 into llvm:main Feb 1, 2025
5 checks passed
@youngar youngar deleted the firrtl-lower-xmr branch February 1, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants