Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a spinner at start of color my world activity #1692

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

AdityaKrSingh26
Copy link

@AdityaKrSingh26 AdityaKrSingh26 commented Dec 29, 2024

Fix to issue : #1691

Issue : Features take 2 seconds to load and if start button is pressed before that it shows a popup -> "Congratulations! You finished!"

Fix : Add a loader screen for 2 seconds so that the activity loads completely in meantime

Screencast.from.2024-12-29.13-21-03.webm

@llaske
Copy link
Owner

llaske commented Dec 29, 2024

Disable the whole screen give a bad experience to users.
Plus the spinner is not the one use in Sugarizer.
Hard coding 2 seconds wait is not a good practice: it could be more or less depending on the device and the network connection.

The better solution will be to detect when the initialization is done and disable the button until it happens.

@AdityaKrSingh26
Copy link
Author

Disable the whole screen give a bad experience to users. Plus the spinner is not the one use in Sugarizer. Hard coding 2 seconds wait is not a good practice: it could be more or less depending on the device and the network connection.

The better solution will be to detect when the initialization is done and disable the button until it happens.

okay i will work on this and fix it

@AdityaKrSingh26
Copy link
Author

AdityaKrSingh26 commented Dec 29, 2024

Is this good enough @llaske ?

Screenshot from 2024-12-30 00-08-04

@llaske
Copy link
Owner

llaske commented Jan 2, 2025

Not sure to understand.
You didn't fix the issue, you've just added a spinner.
The idea is to forbid to click on play before initialization is done.

@AdityaKrSingh26
Copy link
Author

Not sure to understand. You didn't fix the issue, you've just added a spinner. The idea is to forbid to click on play before initialization is done.

I'm sorry i forgot to push some changes. i have pushed the changes where i am preventing any action on click of run button while activity is loading.

Recording.2025-01-05.120904.mp4

@llaske llaske merged commit 9bdd33c into llaske:dev Jan 8, 2025
@llaske
Copy link
Owner

llaske commented Jan 8, 2025

Nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants