Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing basename with nemo specific filename variable %N #595

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

freckhard
Copy link
Contributor

This change replaces the shell-based filename extraction using basename %F with Nemo's native %N filename variable. This simplifies the command, avoids shell quoting issues, and improves reliability.

This change replaces the shell-based filename extraction using basename %F with Nemo's native %N filename variable. This simplifies the command, avoids shell quoting issues, and improves reliability.
@rcalixte
Copy link
Member

rcalixte commented Feb 9, 2025

cc @torchipeppo

@torchipeppo
Copy link
Contributor

torchipeppo commented Feb 10, 2025

Well, TIL :)
I just made a quick test and it appears to be in order.
Actually, I got curious and found the Nemo wiki on GitHub where it says that %N is deprecated and the same as %f (lowercase): is this important enough to warrant a correction?
Source: https://github.com/linuxmint/nemo/wiki/Actions-Quick-Reference

Copy link
Contributor

@torchipeppo torchipeppo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a test with %f the other day and it seems to work just the same, even a quick search in the nemo source code [1] [2] shows they're treated exactly the same.

At this point @rcalixte I'd prefer to avoid what's been marked as deprecated, either by applying this change now or by approving this PR as is and fixing later.

Otherwise @freckhard thank you very much for the thought and the idea! ^_^

…hipeppo.nemo_action.in

Co-authored-by: Francesco Petri <[email protected]>
@rcalixte rcalixte merged commit 022de4c into linuxmint:master Feb 17, 2025
1 check passed
@freckhard freckhard deleted the patch-1 branch February 17, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants