Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change user unit orders #92

Closed
wants to merge 1 commit into from

Conversation

ArchieMeng
Copy link
Contributor

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArchieMeng
Copy link
Contributor Author

/pre-integrate

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 文件路径和目标路径的修改

    • CMakeLists.txt文件中,[email protected]dde-session-pre.target.wants移动到了dde-session-initialized.target.wants。这个改动可能是为了改变服务的启动顺序或依赖关系。需要确认这一改动是否符合预期的服务启动逻辑。
  2. 服务依赖关系

    • [email protected]文件中,RequisitePartOfBefore的值从dde-session-pre.target改为了dde-session-initialized.target。这表明该服务现在依赖于dde-session-initialized.target,而不是之前的dde-session-pre.target。需要确保这一改动不会影响服务的启动顺序和依赖关系。
  3. 代码注释

    • CMakeLists.txt文件中,移除了对[email protected]的注释,这可能会影响其他开发者的理解。建议保留注释,或者添加更详细的说明,解释为什么需要移除该服务。
  4. 文件重命名

    • 文件重命名从dde-session-pre.target.wants/[email protected]dde-session-initialized.target.wants/[email protected]。这个操作是合理的,但需要确保所有相关的配置文件和脚本都已经更新,以反映这一变化。
  5. 安装符号链接

    • CMakeLists.txt文件中,[email protected]的符号链接从dde-session-pre.target.wants移动到了dde-session-initialized.target.wants。这一改动需要与上述的服务依赖关系修改保持一致,以确保服务的正确启动。

总体来说,这些改动看起来是合理的,但需要确保它们不会引入任何新的问题,并且与整个系统的启动逻辑保持一致。建议进行充分的测试,以确保这些改动不会影响系统的稳定性和功能。

Copy link

github-actions bot commented Oct 12, 2024

TAG Bot

TAG: 1.2.14
EXISTED: yes
DISTRIBUTION: UNRELEASED

@ArchieMeng
Copy link
Contributor Author

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2079
PrNumber: 2079
PrBranch: auto-integration-11304131940

@deepin-bot
Copy link

deepin-bot bot commented Oct 23, 2024

TAG Bot

New tag: 1.2.14
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #93

@deepin-bot
Copy link

deepin-bot bot commented Nov 29, 2024

TAG Bot

New tag: 1.99.3
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #101

@deepin-bot
Copy link

deepin-bot bot commented Dec 6, 2024

TAG Bot

New tag: 1.99.4
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #104

@deepin-bot
Copy link

deepin-bot bot commented Dec 14, 2024

TAG Bot

New tag: 1.99.5
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #108

@deepin-bot
Copy link

deepin-bot bot commented Dec 14, 2024

TAG Bot

New tag: 1.99.6
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #113

@deepin-bot
Copy link

deepin-bot bot commented Dec 16, 2024

TAG Bot

New tag: 1.99.7
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #115

@deepin-bot
Copy link

deepin-bot bot commented Dec 27, 2024

TAG Bot

New tag: 1.99.8
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #118

@deepin-bot
Copy link

deepin-bot bot commented Jan 23, 2025

TAG Bot

New tag: 1.99.9
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #121

@ArchieMeng
Copy link
Contributor Author

stalled

@ArchieMeng ArchieMeng closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants