Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.5.19 #2503

Merged
merged 2 commits into from
Dec 20, 2024
Merged

6.5.19 #2503

merged 2 commits into from
Dec 20, 2024

Conversation

Johnson-zs
Copy link
Contributor

No description provided.

1. uncheck an organized collection;
2. change the wallpaper;
3. crash.

the event is not unsubscribed when collection removed at step 1, when
the wallpaper event emitted, the event handler executed with nullptr,
cause crash.
unsubscribe signal when collection destroyed.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-271449.html
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

6.5.19

Log: tag 6.5.19
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • normalizedmode.cpp文件中新增的信号连接和断开连接逻辑可能存在潜在的内存泄漏问题,因为connect函数返回的信号槽连接对象没有被存储,无法手动断开连接。
  • 新增的信号槽连接应该使用Qt::UniqueConnectionQt::QueuedConnection来避免重复连接或队列问题。

是否建议立即修改:

Copy link

TAG Bot

TAG: 6.5.19
EXISTED: no
DISTRIBUTION: unstable

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 20, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 4e598ba into linuxdeepin:master Dec 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants