Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] skip failed tests for xpu #498

Merged
merged 11 commits into from
Jan 24, 2025
Merged

[tests] skip failed tests for xpu #498

merged 11 commits into from
Jan 24, 2025

Conversation

faaany
Copy link
Collaborator

@faaany faaany commented Dec 25, 2024

Summary

Some tests fail on XPU. We are fixing this. But for now, let's skip it for XPU CI.

Below are the test results with "make test" on XPU after the skip:

======================================================== 738 passed, 223 skipped, 42 warnings in 70.34s (0:01:10) =========================================================
  • Hardware Type: Intel(R) Data Center GPU Max 1550
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@faaany
Copy link
Collaborator Author

faaany commented Dec 25, 2024

@yao-matrix

@faaany faaany requested a review from lancerts December 25, 2024 06:06
@faaany
Copy link
Collaborator Author

faaany commented Jan 22, 2025

close, no need to skip as the issue got fixed in the latest pytorch-triton-xpu version.

@faaany faaany closed this Jan 22, 2025
@faaany faaany reopened this Jan 23, 2025
@faaany faaany changed the title [tests] skip core-dump test on xpu [tests] skip failed tests for xpu Jan 23, 2025
@faaany faaany mentioned this pull request Jan 24, 2025
3 tasks
@ByronHsu ByronHsu merged commit 1441a31 into linkedin:main Jan 24, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants