Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar errors #3151

Merged
merged 9 commits into from
Feb 5, 2025
Merged

Fix grammar errors #3151

merged 9 commits into from
Feb 5, 2025

Conversation

Dimitrolito
Copy link
Contributor

  • Corrected typos and inconsistencies in comments and docstrings.
  • Improved clarity in function and variable descriptions for better readability.

afck
afck reviewed Jan 20, 2025
View reviewed changes
linera-core/src/chain_worker/state/mod.rs Outdated Show resolved Hide resolved
linera-base/src/prometheus_util.rs Outdated Show resolved Hide resolved
@Dimitrolito
Copy link
Contributor Author

Hi @afck

Updates have been made:

  • Capitalization of terms such as 'Prometheus' and 'Linera'
  • Replaced 'Clonable' with 'Cloneable'.

ma2bd
ma2bd requested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ma2bd ma2bd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert to ClonableView

@Dimitrolito
Copy link
Contributor Author

@ma2bd Hi, do you mean to revert all changes in the files from 'Cloneable' to 'Clonable'?

@afck
Copy link
Contributor

afck commented Jan 28, 2025

Yes, sorry! "Clonable" is quite common, after all.

@Dimitrolito
Update mod.rs
52facbe 
Signed-off-by: Dmytrol <[email protected]>
@Dimitrolito
Copy link
Contributor Author

@afck
I’ve reverted the changes from "Cloneable" back to "Clonable" as you requested. Please let me know if everything looks good now!

@afck afck merged commit 7aac8ed into linera-io:main Feb 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ma2bd ma2bd ma2bd approved these changes

@afck afck afck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dimitrolito @afck @ma2bd