-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement list_root_keys
to the AdminKeyValueStore
#3142
Open
MathieuDutSik
wants to merge
21
commits into
linera-io:main
Choose a base branch
from
MathieuDutSik:get_root_keys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1a6fc76
Insert the code for the basic stores.
MathieuDutSik db29208
Implement the stuff for the ScyllaDb.
MathieuDutSik d4f5590
Implement the feature for DynamoDb.
MathieuDutSik fc4d4ef
Add now the test for RocksDb.
MathieuDutSik e25c8e1
Change the structure of the "fn build" and implement the root_key
MathieuDutSik affe4b2
Rename the admin_test function.
MathieuDutSik 7b2dc86
Make clone_with_root_key async.
MathieuDutSik 5576660
Some insertion of the code.
MathieuDutSik 655d379
Add more tests.
MathieuDutSik 3f5aed2
Formatting corrections and introduce the get_root_keys to the indexddb.
MathieuDutSik 1c93734
Clippy corrections.
MathieuDutSik 72f1ae5
Rename effective_root_key to start_key.
MathieuDutSik 4c82b70
formatting correction.
MathieuDutSik d40a36f
Several more corrections on the whole code.
MathieuDutSik c689b9e
Resolve the problem of the rocks_db test.
MathieuDutSik 683ed23
Some simplification and correction of full_keys2 entry.
MathieuDutSik 86742ce
Rename the "get_root_keys" as "list_root_keys".
MathieuDutSik 9c87628
Correct the test code + Correct the DynamoDb/ScyllaDb codes.
MathieuDutSik fbb0ec7
Some renaming.
MathieuDutSik 29975ab
Cleanup of the code from the review.
MathieuDutSik 3e78982
Add the functionality to the documentation.
MathieuDutSik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
linera-client
, we know that the "root keys" are (basically) chain ids. So why not list the chain ids instead of abstract root key bytes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And similarly later, we should list ApplicationId, BlobId, etc as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw you may need to add conversion function in
linera-storage
for this.