Fixed create fn to return false if node already exists #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc string says `If the node already exists, create will return false.` but the implementation returned the path of the node instead. I fixed this (so that callers of `create` can distinguish the two cases), but this is a breaking change, so if other code (like e.g. in `avout`) already depends on the "contra-documented" feature, it will break. `create-all` is such an example which could fail due to the change in `create`'s return value, had I not also taken care of that. With the old version of `create-all`, in case of a rare race condition where the node in question is created by another process or thread in-between the call to `(exists ... node)` and the subsequent call to `(create ... node)`,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doc string says
If the node already exists, create will return false.but the implementation returned the path of the node instead.I fixed this (so that callers of
createcan distinguish the two cases), but this is a breaking change, so if other code (like e.g. inavout) already depends on the "contra-documented" feature, it will break.create-allis such an example which could fail due to the change increate's return value, had I not also taken care of that.With the old version of
create-all, in case of a rare race condition where the node in question is created by another process or thread in-between the call to(exists ... node)and the subsequent call to(create ... node),