[fix_phase_called_twice] fix bug that ensure when activate an experim…

…ent - don't allow calling the same phase twice

src_py/apiServer/apiServer.py

@@ -28,6 +28,7 @@ def __init__(self):
         self.experiments_dict = {}
         self.current_exp = None
         self.apiserver_event_sync = EventSync() # pay attention! there are two kinds of syncs one for experiment phase events and one for api-server events
+        self.next_expertiment_phase_exist = True      # flag to check if there are more phases to run
 
         # Create a new folder for the results:
         Path(EXPERIMENT_RESULTS_PATH).mkdir(parents=True, exist_ok=True)
@@ -153,6 +154,7 @@ def send_data_to_sources(self, csv_dataset: CsvDataSet, experiment_phase: Experi
         LOG_INFO("Data is ready in sources")
 
     def run_current_experiment_phase(self):
+        assert self.next_expertiment_phase_exist, "experiment override is not supported!"     # don't allow calling the same phase twice 
         current_exp_phase = self.current_exp.get_current_experiment_phase()
         LOG_INFO(f"Experiment phase: {current_exp_phase.get_name()} of type {current_exp_phase.get_phase_type()} starts running...")
         csv_dataset_inst = self.current_exp.get_csv_dataset()
@@ -179,7 +181,8 @@ def run_current_experiment_phase(self):
         self.communication_stats()
 
         LOG_INFO(f"Phase of {current_exp_phase.get_name()} {current_exp_phase.get_phase_type()} completed")
-
+
+        self.next_expertiment_phase_exist = False  
 
 
     def next_experiment_phase(self):
@@ -189,8 +192,9 @@ def next_experiment_phase(self):
         current_exp_flow.current_exp_phase_index += 1
         if not self.experiment_phase_is_valid():
             LOG_WARNING("No more phases to run")
-            return False
-        return True
+            self.next_expertiment_phase_exist = False
+        else:
+            self.next_expertiment_phase_exist = True
 
     def communication_stats(self):
         assert self.experiment_phase_is_valid(), "No valid experiment phase"

src_py/apiServer/experiment_flow_debug.py

@@ -29,8 +29,7 @@ def print_test(in_str : str):
 experiment_name = "test_exp"
 api_server_instance.initialization(experiment_name, dc_json , connmap_json, exp_flow_json) # start to debug
 api_server_instance.send_jsons_to_devices()
-
-next_expertiment_phase_exist = True 
+
 api_server_instance.run_current_experiment_phase() # blocking - deppended acks from mainserver
 stats = api_server_instance.get_experiment_flow(experiment_name).generate_stats()
 stats.get_communication_stats_workers()
@@ -40,7 +39,7 @@ def print_test(in_str : str):
 stats.get_communication_stats_main_server()
 stats.get_loss_ts()
 stats.get_min_loss()
-next_expertiment_phase_exist = api_server_instance.next_experiment_phase()
+api_server_instance.next_experiment_phase()
 api_server_instance.run_current_experiment_phase()
 stats = api_server_instance.get_experiment_flow(experiment_name).generate_stats()
 confusion_matrix_source_dict, confusion_matrix_worker_dict = stats.get_confusion_matrices()