[CORELIB-182] Fix dotnet and rider warnings, remove StyleCop leftovers

[wojtek2288]

No description provided.

[github-actions]

test: Run #2114

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Pending ⏳	Other ❓	Flaky 🍂	Duration ⏱️
747	746	0	1	0	0	0	198ms

🎉 All tests passed!

Github Test Reporter

🔄 This comment has been updated

[jakubfijalkowski]

Just a question, does it have a problem with the properties set here?

[wojtek2288]

Yes setting it in constructor. https://www.jetbrains.com/help/rider/VirtualMemberCallInConstructor.html For example this might fail:

public class CustomContext : LocalCallContext
{
    private string prefix;

    public CustomContext(
        IServiceProvider requestServices,
        ClaimsPrincipal user,
        string? activityIdentifier,
        IHeaderDictionary? headers,
        CancellationToken cancellationToken
    )
        : base(requestServices, user, activityIdentifier, headers, cancellationToken)
    {
        prefix = "test_";
    }

    public override string TraceIdentifier
    {
        get => base.TraceIdentifier;
        set => base.TraceIdentifier = $"{prefix}{value}";
    }
}

var context = new CustomContext(
    requestServices: serviceProvider,
    user: user,
    activityIdentifier: "123",
    headers: null,
    cancellationToken: CancellationToken.None
);

Because base constructor runs first and calls overridden setter but CustomContext constructor has not run yet and prefix is not initialized so we might get something like Object reference not set to an instance of an object.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (305efc4) to head (fc23912).
Report is 22 commits behind head on v9.0-preview.

Additional details and impacted files

@@         Coverage Diff         @@
##   v9.0-preview   #750   +/-   ##
===================================
===================================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.