Integration test config rework #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One allows to pass arbitrary configuration, the other one manages the connection string. Moreover, connection string injection uses config not from env, but from the "parent" configuration.
test: Run #2101
🎉 All tests passed!🔄 This comment has been updated |
Dragemil
reviewed
Jan 16, 2025
src/Testing/LeanCode.IntegrationTestHelpers/TestConnectionString.cs
Outdated
Show resolved
Hide resolved
Dragemil
approved these changes
Jan 16, 2025
Saancreed
reviewed
Jan 16, 2025
jakubfijalkowski
force-pushed
the
feature/integration-test-config
branch
from
7b8a3d2 to
f21b042
Compare
Saancreed
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9.0-preview #746 +/- ##
===================================
===================================
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two (three) small changes that should make the integration test helpers easier to use:
DbContextInitializerworks with Npgsql now,ConfigurationOverridesallows specifying arbitrary config strings now.Plus, a test connection string management is now in a separate class that loads the connection
string base not from env vars, but from the supplied configuration builder itself. Allows, e.g., to
specify the base connection stirng in
appsettings.jsonfile.