Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to the recent changes #734

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

jakubfijalkowski
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 30, 2024

test: Run #2082

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
742 741 0 1 0 0 0 209ms

🎉 All tests passed!

Github Test Reporter

🔄 This comment has been updated

@marcin-dardzinski
Copy link
Member

Should https://github.com/leancodepl/corelibrary/blob/v9.0-preview/docs/tests/integration_tests/index.md#integration-test should also be updated to use IntegrationFact, plus some invocation magic?

@jakubfijalkowski
Copy link
Member Author

@marcin-dardzinski I don't think so. These attributes are in the test/LeanCode.Test.Helpers project, so no project outside this repo can see it.

@marcin-dardzinski
Copy link
Member

Okay, I was mistaken by the project name. So, maybe outside of this repo, but what are the guidelines for the projects? Are we changing anything there?

@jakubfijalkowski
Copy link
Member Author

jakubfijalkowski commented Dec 30, 2024

@marcin-dardzinski nope, nothing has changed IMO, at least in the context of this repository. ExampleApp is slightly different beast.

@jakubfijalkowski
Copy link
Member Author

Well, maybe one thing - the examples should adjust the interface of IAsyncLifetime.

Base automatically changed from remove-unused-projects to v9.0-preview December 30, 2024 15:32
Co-authored-by: Patryk Pochmara <[email protected]>
@jakubfijalkowski jakubfijalkowski merged commit d54cf21 into v9.0-preview Dec 30, 2024
4 checks passed
@jakubfijalkowski jakubfijalkowski deleted the update-readme branch December 30, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants