Seal classes that can be sealed

leancodepl · Feb 8, 2024 · 925267d · 925267d
1 parent 124155f
commit 925267d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -35,7 +35,6 @@ dotnet_style_predefined_type_for_member_access                           = true
 dotnet_style_readonly_field                                              = true : suggestion
 
 dotnet_style_require_accessibility_modifiers                             = always : warning
-csharp_preferred_modifier_order                                          = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async : warning
 
 dotnet_style_object_initializer                                          = true : suggestion
 dotnet_style_collection_initializer                                      = true : suggestion

diff --git a/test/CQRS/LeanCode.CQRS.AspNetCore.Tests/Registration/CQRSApiDescriptionProviderTests.cs b/test/CQRS/LeanCode.CQRS.AspNetCore.Tests/Registration/CQRSApiDescriptionProviderTests.cs
@@ -241,7 +241,7 @@ public Task<OperationResultDTO> ExecuteAsync(HttpContext context, Operation oper
         throw new NotImplementedException();
 }
 
-internal class DummyEndpointDataSource : EndpointDataSource
+internal sealed class DummyEndpointDataSource : EndpointDataSource
 {
     public override IReadOnlyList<Endpoint> Endpoints => throw new NotImplementedException();
 

diff --git a/test/CQRS/LeanCode.CQRS.AspNetCore.Tests/ServiceProviderRegistrationExtensionsTests.cs b/test/CQRS/LeanCode.CQRS.AspNetCore.Tests/ServiceProviderRegistrationExtensionsTests.cs
@@ -94,7 +94,7 @@ private static ServiceProvider BuildProvider(Action<CQRSServicesBuilder>? config
         return collection.BuildServiceProvider();
     }
 
-    internal class CustomSerializer : ISerializer
+    internal sealed class CustomSerializer : ISerializer
     {
         public ValueTask<object?> DeserializeAsync(
             Stream utf8Json,
@@ -111,7 +111,7 @@ CancellationToken cancellationToken
     }
 }
 
-file class ServiceProviderAssertions : ReferenceTypeAssertions<ServiceProvider, ServiceProviderAssertions>
+file sealed class ServiceProviderAssertions : ReferenceTypeAssertions<ServiceProvider, ServiceProviderAssertions>
 {
     protected override string Identifier => "services";