Patch 1 #153
Open
Patch 1 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step to correct this was properly handling how the vms_list file was being created (parsed output from vim-cmd vmsvc/getallvms) additional variables are then created, prefixed with "esc_" containing the proper escape sequence for VM Names when used in various subsequent commands. Original variable names are kept as they are still used in places where the escaping is not needed, such as in logging. Additional special characters can be handled by modifying the sed statement on line 959. The restore script will also need to be updated.
Space missing in conditional which triggered ash error.
Did not need to escape the parenthesis in the sed statement
|
I believe this will also add the functionality requested for spaces in Issue #84 I'd have to look closer to see if it also addresses the brackets. |
|
this is great, it is able to grep the vm names with brackets when backing up.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow square brackets and parenthesis in VM names