[1.29] sig-release: change go version for go-compat jobs #34062
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
|
/approve cc @kubernetes/release-managers |
k8s-ci-robot
added
the
lgtm
config/jobs/kubernetes/sig-release/release-branch-jobs/1.29.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Madhav Jivrajani <[email protected]>
MadhavJivrajani
force-pushed
the
go-compat-129-jobs
branch
from
afc9cea to
6a4dbca
Compare
k8s-ci-robot
removed
the
lgtm
MadhavJivrajani
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -1935,7 +1935,7 @@ presubmits: | |||
| - test | |||
| env: | |||
| - name: GO_VERSION | |||
| value: 1.21.4 | |||
| value: 1.22.10 | |||
There was a problem hiding this comment.
/hold
we shouldn't be bumping these up minor versions without discussion… the point is to make sure these pass on the original go minor the kubernetes minor was released on
There was a problem hiding this comment.
seems right, thanks for the reminder
/lgtm cancel
|
Until we can set godebug defaults (which requires go1.23, we shouldn't do anything that requires bumping go minors) |
k8s-ci-robot
removed
the
lgtm
I think it's probably reasonable to change these concurrent with updating to build with go1.23 AND setting |
| @@ -1758,7 +1758,7 @@ presubmits: | |||
| - runner.sh | |||
| env: | |||
| - name: GO_VERSION | |||
| value: 1.21.4 | |||
| value: 1.22.10 | |||
There was a problem hiding this comment.
Why do we have manually encoded go versions here anyhow? We should not be constantly PR-ing specific go versions in more places. If we're trying to test something like "use the latest patch version" we should automatically determine and use that?
There was a problem hiding this comment.
I see: kubernetes/kubernetes#126713 (comment)
We could probably obtain that value from git but it would be slightly more complex ... and we'd still have a problem in this case.
There was a problem hiding this comment.
We could probably obtain that value from git but it would be slightly more complex
we snapshot it from git at the point in time when the minor jobs are forked (https://github.com/kubernetes/test-infra/blob/master/releng/prepare_release_branch.py#L144) :)
less runtime indication and magic is easier to reason about, in my opinion
There was a problem hiding this comment.
Yeah, this looked like something we'd be updating regularly, which we should dedupe. Doesn't seem worth it if it's meant to be fixed per branch, we should document this job #34062 (comment)
There was a problem hiding this comment.
Can we please put a description annotation on this job?
https://github.com/kubernetes/test-infra/blob/master/testgrid/config.md#prow-job-configuration
|
("go compat" is ambiguous and if you don't already know, the intent of these jobs is not clear, I forgot we had these to ensure compat with the original release version, we have a standardized field that will show in testgrid etc to describe a job, we should use that) |
Changing the go version of the compatibility job to be 1.22.9 which is the go version of the latest K8s 1.29 patch release
Needed for bumping K8s release-1.29 to go1.23
See kubernetes/kubernetes#126713 (comment)
/assign @liggitt @dims
/hold
for discussion if needed