Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presubmits for kubedns/nodelocaldns bumps #33962

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

DamianSawicki
Copy link
Contributor

This is to detect regressions before merging rather than by inspecting the periodic test grid after merging. Such inssues happened at least twice recently at kubernetes/kubernetes#123590 and kubernetes/kubernetes#129230.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 16, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 16, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 16, 2024
@aojea
Copy link
Member

aojea commented Dec 16, 2024

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 16, 2024
@k8s-ci-robot
Copy link
Contributor

@marqc: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@DamianSawicki DamianSawicki marked this pull request as ready for review December 16, 2024 14:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot requested a review from bowei December 16, 2024 14:15
@aojea
Copy link
Member

aojea commented Dec 16, 2024

config_test.go:512: Job pull-kubernetes-e2e-gci-gce-kube-dns-nodecache does not have a matching testgrid testgroup

check other jobs, or you add an annotation or you add the job to the configs/testgrid/... file, I never remember which one is better or simpler

@DamianSawicki
Copy link
Contributor Author

config_test.go:512: Job pull-kubernetes-e2e-gci-gce-kube-dns-nodecache does not have a matching testgrid testgroup

check other jobs, or you add an annotation or you add the job to the configs/testgrid/... file, I never remember which one is better or simpler

I guess what is missing is something like

    annotations:
      testgrid-dashboards: sig-network-gce
      testgrid-tab-name: presubmit-network-nftables, google-gce

Looking at the following comment

  # Note, these jobs need to generally stage results to a GCE bucket.
  # We currently have three, ingress, network-policies , and ipvs...

it seems like I need to pick one of presubmit-network-ingress, presubmit-network-policies, presubmit-network-ipvs or perhaps presubmit-network-nftables, which seems to be the fourth one added later. Or can I just use any string and such a bucket will be created automatically?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2024
This is to detect regressions before merging rather than by inspecting
the periodic test grid after merging. Such inssues happened at least twice
recently at kubernetes/kubernetes#123590 and
kubernetes/kubernetes#129230.

Signed-off-by: Damian Sawicki <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@marqc: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, DamianSawicki, marqc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member

aojea commented Dec 17, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@aojea
Copy link
Member

aojea commented Dec 17, 2024

marqc approved these changes 9 hours ago

@marqc you need to use commands on comments /lgtm or /approve in kubernetes org

@k8s-ci-robot k8s-ci-robot merged commit 52463bc into kubernetes:master Dec 17, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@DamianSawicki: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

This is to detect regressions before merging rather than by inspecting the periodic test grid after merging. Such inssues happened at least twice recently at kubernetes/kubernetes#123590 and kubernetes/kubernetes#129230.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants