-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presubmits for kubedns/nodelocaldns bumps #33962
Add presubmits for kubedns/nodelocaldns bumps #33962
Conversation
Skipping CI for Draft Pull Request. |
3c2c0e5
to
d52cb77
Compare
d52cb77
to
69f2ca1
Compare
/lgtm Thanks |
@marqc: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
check other jobs, or you add an annotation or you add the job to the configs/testgrid/... file, I never remember which one is better or simpler |
I guess what is missing is something like
Looking at the following comment
it seems like I need to pick one of |
69f2ca1
to
1b47892
Compare
This is to detect regressions before merging rather than by inspecting the periodic test grid after merging. Such inssues happened at least twice recently at kubernetes/kubernetes#123590 and kubernetes/kubernetes#129230. Signed-off-by: Damian Sawicki <[email protected]>
1b47892
to
b80d112
Compare
@marqc: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, DamianSawicki, marqc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@marqc you need to use commands on comments |
@DamianSawicki: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is to detect regressions before merging rather than by inspecting the periodic test grid after merging. Such inssues happened at least twice recently at kubernetes/kubernetes#123590 and kubernetes/kubernetes#129230.