Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stopgap: allow branch protector to run for longer #33901

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Dec 3, 2024

ref: #33900

not a real fix, but maybe we can get the rules sync.

TODO: can we afford to raise the rate limit? (we did before by >3x, not sure how much spare capacity we have)

cc @kubernetes/owners @kubernetes/sig-testing-leads

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and upodroid December 3, 2024 21:58
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 3, 2024
@dims
Copy link
Member

dims commented Dec 3, 2024

/approve
/lgtm

better than status quo (failing constantly)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 06c1dfe into kubernetes:master Dec 3, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-testing-branchprotector.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/sig-testing-branchprotector.yaml

In response to this:

ref: #33900

not a real fix, but maybe we can get the rules sync.

TODO: can we afford to raise the rate limit? (we did before by >3x, not sure how much spare capacity we have)

cc @kubernetes/owners @kubernetes/sig-testing-leads

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the longertime branch December 3, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants