-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize the hardcoded images used for warmpool pre-pulling #17144
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
4a88289
to
172ea41
Compare
172ea41
to
a01e7b8
Compare
@rifelpet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #16871
When AWS WarmPool is enabled, nodeup pre-pulls a hardcoded list of images based on the cluster's assets:
https://github.com/rifelpet/kops/blob/4a882890ff2addb1ae0f69f93280102969ab64d3/pkg/nodemodel/nodeupconfigbuilder.go#L490-L507
When a cluster has:
All of the assets are remapped to begin with the containerProxy value. This results in the WarmPool logic not matching against any of the cluster's assets, and nodeup doesn't treat the instance as being in the warm pool.
Now we run the hardcoded images through the same remapping logic to ensure its matched against any images used in the cluster's assets.