-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3633: graduate MatchLabelKeys in PodAffinity to GA #5021
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanposhiho The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -3,3 +3,5 @@ alpha: | |||
approver: "@wojtek-t" | |||
beta: | |||
approver: "@wojtek-t" | |||
stable: | |||
approver: "@wojtek-t" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @wojtek-t
Please assign it to another person if needed. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: keep the newline.
/assign @Huang-Wei @alculquicondor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The KEP's readme.md needs to be updated as well:
- Implementation History
- PRR section
- Testing coverage
- etc...
@@ -3,3 +3,5 @@ alpha: | |||
approver: "@wojtek-t" | |||
beta: | |||
approver: "@wojtek-t" | |||
stable: | |||
approver: "@wojtek-t" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: keep the newline.
@@ -13,9 +13,9 @@ approvers: | |||
see-also: | |||
- "/keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades" | |||
|
|||
stage: beta | |||
stage: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in L29, change disable-supported to false.
MatchLabelKeys
to Pod Affinity and Pod Anti Affinity #3633