-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-5007: DRA Device Attach Before Pod Scheduled #5012
base: master
Are you sure you want to change the base?
KEP-5007: DRA Device Attach Before Pod Scheduled #5012
Conversation
KobayashiD27
commented
Dec 20, 2024
- One-line enhancement description: Some network- or fabric-attached devices need to be attached to a node before a pod using them can be scheduled.
- Issue link: DRA: attach devices to nodes #5007
- Other comments:
Hi @KobayashiD27. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pohly |
|
||
In this scenario, the ResourceSlice representing a same fabric device might be selected in multiple Kubernetes clusters simultaneously. If the attachment fails in one cluster, the pod will remain in a failed state in kubelet. | ||
|
||
By having the scheduler wait for the fabric device to be attached, we can reschedule the pod if the attachment fails. This approach is superior because it avoids unnecessary waiting and allows for immediate rescheduling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am new to this area of CDI, but would appreciate if we can show how this para is more tightly related to the proposal ? For example does this make it easier to attach requested resource directly to the node where the pod is about to be scheduled or some other example like https://cdi.liqid.com/hubfs/Inference-aaS-WP_FNL.pdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current implementation, device attachment is executed by NodePrepareResource() after the Pod has been scheduled. However, if the device cannot be attached to the node at this stage, NodePrepareResource() will continue to fail, and the user will see the ContainerCreating state persist (internally, it will keep failing indefinitely). This issue is particularly problematic when fabric devices are shared across multiple Kubernetes clusters, as these clusters may compete for resources, leading to situations where device attachment fails.
Implementing this proposal will help avoid the persistent ContainerCreating state. By streamlining the process of attaching the requested resource directly to the node where the Pod is scheduled, the risk of device attachment failure is reduced. Consequently, this enhances the overall reliability of the system and prevents resource wastage.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KobayashiD27 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |