Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEST: GCP e2e test #1701

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

TEST: GCP e2e test #1701

wants to merge 6 commits into from
+114 −5

Conversation

dargudear-google
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @dargudear-google. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

@dargudear-google: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-secrets-store-csi-driver-e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2024
@aramase
Copy link
Member

aramase commented Dec 6, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2024
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

2 similar comments
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

4 similar comments
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

1 similar comment
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

7 similar comments
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 9, 2024
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

3 similar comments
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2024
@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dargudear-google
Once this PR has been reviewed and has the lgtm label, please assign aramase for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dargudear-google
Copy link
Contributor Author

/test pull-secrets-store-csi-driver-e2e-gcp

@k8s-ci-robot
Copy link
Contributor

@dargudear-google: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-secrets-store-csi-driver-e2e-gcp fecd966 link false /test pull-secrets-store-csi-driver-e2e-gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase Awaiting requested review from aramase

@nilekhc nilekhc Awaiting requested review from nilekhc

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dargudear-google @k8s-ci-robot @aramase