-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add s390x, ppc64le support #1637
base: main
Are you sure you want to change the base?
add s390x, ppc64le support #1637
Conversation
Hi @Basavaraju-G. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Basavaraju-G The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
- Coverage 35.83% 35.74% -0.09%
==========================================
Files 63 63
Lines 3759 3754 -5
==========================================
- Hits 1347 1342 -5
- Misses 2268 2269 +1
+ Partials 144 143 -1 ☔ View full report in Codecov by Sentry. |
/test pull-secrets-store-csi-driver-e2e-windows |
/test pull-secrets-store-csi-driver-e2e-azure |
Hi @Basavaraju-G Thanks for the PR. Could you also add it here - https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/docker/BASEIMAGE? Try running https://github.com/kubernetes-sigs/secrets-store-csi-driver/blob/main/docker/build.sh locally and see if it works. You can also post output of your local build here. |
Sure. will post build data here. |
|
7eced97
to
2202e45
Compare
Hi @nilekhc i have added the baseimage for s390x, ppc64le. would you please take a look? thanks |
/test pull-secrets-store-csi-driver-e2e-provider-k8s-1-29-4 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -61,7 +61,7 @@ export GOPATH GOBIN GO111MODULE DOCKER_CLI_EXPERIMENTAL | |||
|
|||
# Generate all combination of all OS, ARCH, and OSVERSIONS for iteration | |||
ALL_OS = linux windows | |||
ALL_ARCH_linux ?= amd64 arm64 | |||
ALL_ARCH_linux ?= amd64 arm64 s390x ppc64le |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If upstream Kube is no longer supporting, should we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of PR is this?
This PR Will add IBM s390x,ppc64le cpu architecture support.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: