Replace time.Now() with clock.Clock.Now() in pkg/pod

[TusharMohapatra07]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Replaces time.Now() to use the Now() function present inside clock package.

Which issue(s) this PR fixes:

Part of #3380

Special notes for your reviewer:

This PR is work-in-progress.

NONE

[k8s-ci-robot]

Hi @TusharMohapatra07. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	4aee186
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6759e61474d18b0008db53c8

[mbobrovskyi]

/ok-to-test

[mbobrovskyi]

Please take a look at this

kueue/pkg/controller/jobs/pod/pod_controller.go

Line 1331 in bd1b989

replCond.LastTransitionTime = metav1.Now()

as well.

[mbobrovskyi]

I think here

kueue/pkg/controller/jobs/pod/pod_controller.go

Line 778 in bd1b989

lastTransition := metav1.Now()

we don't need Now(). Please optimize it.

[mbobrovskyi]

/test all

[mbobrovskyi]

/lgtm
Thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi, TusharMohapatra07
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 61d3b47cefc9c126048fe8f7e1ba6dcc33707d7f

[mimowo]

Instead a function like this - can we please make sure the clock is always set, this will make the code much simpler to reason about, and can prevent panics when someone assumes it is set and forgets to call the function. It is very hard to see this type of a bug when reviewing and seeing on GH only fragment of the code.

[TusharMohapatra07]

@mimowo So, pod doesnot have a constructor so, we can no more implement options in it. What other approach do you think would fit in this situation ?

[mimowo]

I synced with @PBundyra and he should be able to help more, but I think it you could make this work with:

• make the lastActiveTime and sortInactivePods to be receiving the (p *Pod) received from FindMatchingWorkloads
• then we could have a function like NewPod accepting the clock (possibly as an option). In production code pass the real clock, and in tests the fake one

You can follow the pattern for the WorkloadReconciler from workload_controller.go

[TusharMohapatra07]

What all fields should i include in the argument so that it must and should be passed while called (rest could be made passed as an option)

type Pod struct {
	pod                   corev1.Pod
	key                   types.NamespacedName
	isFound               bool
	isGroup               bool
	unretriableGroup      *bool
	list                  corev1.PodList
	absentPods            int
	excessPodExpectations *expectations.Store
	satisfiedExcessPods   bool
}

For Example, in NewWorkloadReconciler, we must pass client, queues, cache and recorder:

NewWorkloadReconciler(client client.Client, queues *queue.Manager, cache *cache.Cache, recorder record.EventRecorder, opts ...Option) *WorkloadReconciler

cc: @mimowo @PBundyra @mbobrovskyi