Publish ingress-nginx service address if manual address not specified and not using host network

[ThisIsQasim]

…ed and not using host network

What type of PR is this?
/kind feature

What this PR does / why we need it:
Advertises the correct service address if no manual address if defined and not using host networking

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Automatically publish ingress-nginx service address if manual address is not specified and ingress-nginx is not using host network

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ThisIsQasim
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @ThisIsQasim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yankay]

/ok-to-test

[ThisIsQasim]

test failures seem related to infra provisioning and not to the PR

[tico88612]

Could you rebase your PR to our master branch?

[ThisIsQasim]

I have rebased and pushed again @tico88612

[yankay]

The --publish-service option should be used only when publishService is enabled, as indicated in the params.tpl file.

Do the changes better:

{% elif ingress_nginx_host_network  != "" %}

[ThisIsQasim]

The three options i.e. reporting a manual IP, reporting node IPs or reporting the IP of a service are mutually exclusive. So if the first two aren't configured it makes sense to default to the third. Especially since we started adding a LoadBalancer service by default so we should publish it's address by default as well.

ingress_nginx_host_network is declared as a boolean why would I check if it is an empty string?

[ThisIsQasim]

or do you mean the following suggestion?

Suggested change

	{% else %}
	{% elif ingress_nginx_publish_service != "" %}