Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm] add helm chart for jobset #760

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Helm] add helm chart for jobset #760

wants to merge 1 commit into from

Conversation

slin1237
Copy link

What type of PR is this?

/kind regression
Adds helm chart for jobset

What this PR does / why we need it:

Some organizations are fully dependent on helm installation, thus jobset should provide an official helm chart for installation

Which issue(s) this PR fixes:

Fixes #726

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Jan 21, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 21, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: slin1237 / name: Simo Lin (2465ed7)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: slin1237
Once this PR has been reviewed and has the lgtm label, please assign danielvegamyhre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @slin1237!

It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/jobset has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @slin1237. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 21, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 2465ed7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/67904e316ed68700083945d6

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 21, 2025
@kannon92
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2025
@kannon92
Copy link
Contributor

/remove-kind regression
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Jan 21, 2025
kannon92
kannon92 reviewed Jan 21, 2025
View reviewed changes
charts/jobset/README.md Outdated
| image.repository | string | `"jobset-controller"` | |
| image.tag | string | `""` | |
| imagePullSecrets | list | `[]` | |
| kubeRbacProxy.image.pullPolicy | string | `"IfNotPresent"` | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dropped kubeRbacPolicy and it will be dropped in 0.8.0. Let's focus on that for now.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i missed that update from main.go
updated the rbac and removed kube rbac proxy

andreyvelich
andreyvelich reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @slin1237!
Do we want to explore @tenzen-y's script that converts kustomize manifests to the Helm charts ?
https://github.com/kubernetes-sigs/kueue/blob/main/hack/update-helm.sh

@slin1237
Copy link
Author

Thank you for doing this @slin1237! Do we want to explore @tenzen-y's script that converts kustomize manifests to the Helm charts ? https://github.com/kubernetes-sigs/kueue/blob/main/hack/update-helm.sh

i have not tried it yet
i looked through the code, its tailored for kueue, its something we can add as a follow up?
it would be nice to automate this, we also have a pretty big operator that requires this config and helm chart sync

@kannon92
Copy link
Contributor

i have not tried it yet
i looked through the code, its tailored for kueue, its something we can add as a follow up?
it would be nice to automate this, we also have a pretty big operator that requires this config and helm chart sync

I would really like to see automation for generating this from day 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvegamyhre danielvegamyhre Awaiting requested review from danielvegamyhre

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@kannon92 kannon92 Awaiting requested review from kannon92

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart for JobSet
4 participants
@slin1237 @k8s-ci-robot @kannon92 @andreyvelich