Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PowerVS CI to k8s v1.31 #2158

Merged

Conversation

priyanshikhetwani
Copy link
Contributor

What this PR does / why we need it:
Bump PowerVS CI to k8s v1.31

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2084

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Bump PowerVS CI to k8s v1.31

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @priyanshikhetwani. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2025
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 88e1259
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/679b17a0eddeef000845ae43
😎 Deploy Preview https://deploy-preview-2158--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Amulyam24
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2025
@Amulyam24
Copy link
Contributor

Thank you for the PR @priyanshikhetwani!

Please confirm if the images are imported to the workspaces used in CI.

@Prajyot-Parab
Copy link
Contributor

Prajyot-Parab commented Jan 30, 2025

Thank you for the PR @priyanshikhetwani!

Please confirm if the images are imported to the workspaces used in CI.

+we should be also updating 1.30 related image info here right @Amulyam24 ?

@Amulyam24
Copy link
Contributor

Thank you for the PR @priyanshikhetwani!
Please confirm if the images are imported to the workspaces used in CI.

+we should be also updating 1.30 related image info here right @Amulyam24 ?

that's right, the info should be updated in the doc.

@priyanshikhetwani
Copy link
Contributor Author

Thank you for the PR @priyanshikhetwani!
Please confirm if the images are imported to the workspaces used in CI.

+we should be also updating 1.30 related image info here right @Amulyam24 ?

that's right, the info should be updated in the doc.

Thank you for the PR @priyanshikhetwani!
Please confirm if the images are imported to the workspaces used in CI.

+we should be also updating 1.30 related image info here right @Amulyam24 ?

that's right, the info should be updated in the doc.

Updated docs for 1.30 as well.
For importing images to CI Workspaces, I don't have write access to account, I'll confirm once imported

@priyanshikhetwani
Copy link
Contributor Author

Updated docs for 1.30 as well. For importing images to CI Workspaces, I don't have write access to account, I'll confirm once imported

Images are now imported

Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prajyot-Parab, priyanshikhetwani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit 58c99ac into kubernetes-sigs:main Jan 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and publish machine images with k8s version 1.30 & 1.31
4 participants