Proposal for adding Additional Disks to node #2139

anshuman-agarwala · 2025-01-21T15:34:56Z

What this PR does / why we need it:
Adds a proposed for resolving #1920
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

k8s-ci-robot · 2025-01-21T15:35:06Z

Hi @anshuman-agarwala. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2025-01-21T15:35:15Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`c8e2757`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/679b3d8508b1f500080fc23f
😎 Deploy Preview	https://deploy-preview-2139--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Karthik-K-N · 2025-01-24T06:03:19Z

docs/proposal/additional-disks.md

+
+## Proposal
+We will need to make changes to both the API and the controller logic.
+With regards to the API, we will need to add a new `AdditionalVolumes` field to the Machine Spec to contain all the different volumes that are added to the node, the field will be a slice of type `VPCVolume`. As an initial design we can keep the field [append-only](https://kubernetes.io/blog/2022/09/29/enforce-immutability-using-cel/#append-only-list-of-containers).


It would be great if you can add pseudo go struct along with theoretical explanation. We can better understand the fields of VPCVolume

Added pseudo-struct for AdditionalVolumes and added a link to existing VPCVolume struct.

mkumatag

overall proposal sounds good, lets add the expected changes to the api spec. And also information from the proposal can be split into multiple sections like api section, limitations etc..

Karthik-K-N

LGTM

@Prajyot-Parab Please take a look

mkumatag · 2025-01-29T05:50:24Z

/ok-to-test
/lgtm
/approve
/hold for others to review

Prajyot-Parab · 2025-01-29T11:00:18Z

/lgtm

mkumatag · 2025-01-29T15:00:04Z

docs/proposal/additional-disks.md

+	// +kubebuilder:validation:MaxItems=10
+	// +kubebuilder:validation:XValidation:rule="oldSelf.all(x, x in self)",message="Values may only be added"
+	AdditionalVolumes []*VPCVolume `json:additionalVolumes,omitempty`
+```


@anshuman-agarwala its worth adding some examples as well.

Added sample manifest for AdditionalVolumes

k8s-ci-robot · 2025-01-29T15:00:16Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anshuman-agarwala
Once this PR has been reviewed and has the lgtm label, please ask for approval from mkumatag. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-01-30T06:05:45Z

New changes are detected. LGTM label has been removed.

mkumatag · 2025-01-30T06:29:28Z

docs/proposal/additional-disks.md

+spec:
+  additionalVolumes:
+  - deleteVolumeOnInstanceDelete: true
+    encryptionKeyCRN: value


lets keep it simple, we have never tested or done anything with this encryptionKeyCRN thing! remanning values looks fine

Removed encryptionKeyCRN from the manifest.

mkumatag · 2025-01-30T06:30:10Z

docs/proposal/additional-disks.md

+    name: VolumeName
+    profile: "general-purpose"
+    sizeGiB: 1
+  - deleteVolumeOnInstanceDelete: true


to make it interesting we can remove deleteVolumeOnInstanceDelete

and also have one example with required entry only, may be thing can be a first entry in the list

Adding comments for each entry here will be better to tell what this kind of volume it is

Added a minimal example, comments and removed the deleteVolumeOnInstanceDelete field.

mkumatag · 2025-01-30T08:15:15Z

docs/proposal/additional-disks.md

+  - iops: 10000
+    name: CustomVolume
+    profile: "custom" # Using a custom profile allows us more freedom when choosing the volume spec
+    sizeGiB: 15000


size seems to be unrealistic, may be 100, 120 or 200 sounds reasonable

mkumatag · 2025-01-30T08:15:37Z

docs/proposal/additional-disks.md

+  bootVolume:
+    name: BootVolume
+    profile: "general-purpose"
+    sizeGiB: 10000


size seems to be unrealistic, may be 100, 120 or 200 sounds reasonable

k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2025

k8s-ci-robot requested review from Amulyam24 and mkumatag January 21, 2025 15:35

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 21, 2025

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 21, 2025

Karthik-K-N reviewed Jan 24, 2025

View reviewed changes

mkumatag requested changes Jan 24, 2025

View reviewed changes

anshuman-agarwala force-pushed the additional-disk-prop branch from 235af63 to 8291dac Compare January 25, 2025 05:38

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2025

Karthik-K-N reviewed Jan 28, 2025

View reviewed changes

k8s-ci-robot assigned mkumatag Jan 29, 2025

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2025

mkumatag approved these changes Jan 29, 2025

View reviewed changes

k8s-ci-robot assigned Prajyot-Parab Jan 29, 2025

mkumatag mentioned this pull request Jan 29, 2025

[WIP]: Add listener based on the machine label and listener label #2155

Open

mkumatag requested changes Jan 29, 2025

View reviewed changes

k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025

anshuman-agarwala force-pushed the additional-disk-prop branch from 8291dac to 055988e Compare January 30, 2025 06:05

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2025

mkumatag requested changes Jan 30, 2025

View reviewed changes

anshuman-agarwala force-pushed the additional-disk-prop branch from 055988e to ce882c5 Compare January 30, 2025 06:51

mkumatag requested changes Jan 30, 2025

View reviewed changes

Proposal for adding Additional Disks to node

c8e2757

anshuman-agarwala force-pushed the additional-disk-prop branch from ce882c5 to c8e2757 Compare January 30, 2025 08:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposal for adding Additional Disks to node #2139

Proposal for adding Additional Disks to node #2139

anshuman-agarwala commented Jan 21, 2025

k8s-ci-robot commented Jan 21, 2025

netlify bot commented Jan 21, 2025 •

edited

Loading

Karthik-K-N Jan 24, 2025

anshuman-agarwala Jan 25, 2025

mkumatag left a comment •

edited

Loading

Karthik-K-N left a comment

mkumatag commented Jan 29, 2025

Prajyot-Parab commented Jan 29, 2025

mkumatag Jan 29, 2025

anshuman-agarwala Jan 30, 2025

k8s-ci-robot commented Jan 29, 2025

k8s-ci-robot commented Jan 30, 2025

mkumatag Jan 30, 2025

anshuman-agarwala Jan 30, 2025

mkumatag Jan 30, 2025

mkumatag Jan 30, 2025

mkumatag Jan 30, 2025

anshuman-agarwala Jan 30, 2025

mkumatag Jan 30, 2025

anshuman-agarwala Jan 30, 2025

mkumatag Jan 30, 2025

anshuman-agarwala Jan 30, 2025

Proposal for adding Additional Disks to node #2139

Are you sure you want to change the base?

Proposal for adding Additional Disks to node #2139

Conversation

anshuman-agarwala commented Jan 21, 2025

k8s-ci-robot commented Jan 21, 2025

netlify bot commented Jan 21, 2025 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkumatag left a comment • edited Loading

Choose a reason for hiding this comment

Karthik-K-N left a comment

Choose a reason for hiding this comment

mkumatag commented Jan 29, 2025

Prajyot-Parab commented Jan 29, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 29, 2025

k8s-ci-robot commented Jan 30, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Jan 21, 2025 •

edited

Loading

mkumatag left a comment •

edited

Loading