-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Download Cluster API CRDs for every integration test #340
🌱 Download Cluster API CRDs for every integration test #340
Conversation
Hi @dmvolod. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c4ab2fd
to
b5164ef
Compare
b5164ef
to
7967a26
Compare
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmvolod, Jont828 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This MR automates loading of Cluster API CRDs into the /tmp directory from the local go mod, needed for integration tests. Avoiding local storage and updating of Cluster API CRDs inside the project repositoty.
This will allow you not to monitor the contents of the CRD in case of updating the version of the Cluster API.
Also automates golang version detection for the build docker image, avoid mainitaning updates inside Makefile.
Also fixes KUBECACHEDIR redefinintion missed in #322
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #