Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing changes form master to release-0.6 #811

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Adding missing changes form master to release-0.6 #811

merged 7 commits into from
Jan 31, 2025

Conversation

sushanth0910
Copy link
Contributor

What this PR does / why we need it:

Adding missing changes form master to release-0.6

#416 

#506
#777
4100368

pulled changes from file/mapper_test.go as file doesnt exist during pulling following change
commit to master d0feaf4
commit to release 
3a0571c

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

logandavies181 and others added 7 commits January 31, 2025 01:27
@logandavies181 @sushanth0910
Add SSO Role suffix support (kubernetes-sigs#416)
3d3a079 
Add SSO Role suffix support.

This change adds the ability to match AWS SSO roles without needing to know the random suffix.

This solves the issue of teams that use AWS SSO roles and aws-iam-authenticator (including EKS users) from needing to keep their configurations up-to-date with the random suffixes that AWS SSO applies to roles it creates. This also has the side-effect of making SSO roles more intuitive to work with.
@logandavies181 @sushanth0910
Support un-canonicalized ARNs in filemapper
673b441
@richzli @sushanth0910
simplify featuregate flag parsing for SSORoleMatch
b2db144
@kanwren @sushanth0910
Fix credential expirability check
676ccce 
Fixes a bug introduced during the refactor in
e92213c, which incorrectly inverted the
previous credential expirability checking logic. This caused errors
about being unable to cache otherwise cachable credentials.

Also changes the error log around the previous expirability check site
to no longer log the error that previously came from the `ExpiresAt()`
check; since this is now the wrong `err`, it's always `nil`.

Addresses kubernetes-sigs#776
@kanwren @sushanth0910
Remove no-op err assignment
adb560e
@sushanth0910
Cherry-picked file changes from commit https://github.com/kubernetes-…
f55fa7a 
…sigs/aws-iam-authenticator/pull/554/commits
@sushanth0910
small fixes missed during cherrypicking
140ea06
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sushanth0910. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 31, 2025
@bryantbiggs
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2025
@kmala
Copy link
Contributor

kmala commented Jan 31, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala, sushanth0910, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot merged commit ffae63b into kubernetes-sigs:release-0.6 Jan 31, 2025
6 checks passed
@sushanth0910 sushanth0910 mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yue9944882 yue9944882 yue9944882 approved these changes

@jyotimahapatra jyotimahapatra Awaiting requested review from jyotimahapatra

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@kmala kmala

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sushanth0910 @k8s-ci-robot @bryantbiggs @kmala @yue9944882 @logandavies181 @richzli @kanwren