feat(ws): Notebooks 2.0 // Frontend // Workspaces details // Activity tab #171

[asaadbalum]

[paulovmr]

Hi @asaadbalum , thanks for the PR! LGTM, I've left two inline comments about the naming. Also, there are some formatting issues, that can be fixed by npm run test:fix.
Apart from that, the DCO check is failing on this PR.

[paulovmr]

/ok-to-test

[paulovmr]

/lgtm

[paulovmr]

Hi @asaadbalum, there is one important thing to change: the style of the overview tab (WorkspaceDetailsOverview.tsx) was changed, so this PR should match it:

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[asaadbalum]

Hi @asaadbalum, there is one important thing to change: the style of the overview tab (WorkspaceDetailsOverview.tsx) was changed, so this PR should match it:

Modified

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: paulovmr
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ederign]

Hi @asaadbalum the code looks ok, but can you please introduce some tests for it? We need to improve our coverage.