feat(ws): Notebooks 2.0 // FrontEnd // Add CPU and RAM columns #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Senan Zedan (EXT-Nokia) <[email protected]>
paulovmr
suggested changes
Jan 3, 2025
added 6 commits
January 6, 2025 16:35
Signed-off-by: Senan Zedan (EXT-Nokia) <[email protected]>
paulovmr
suggested changes
Jan 6, 2025
added 2 commits
January 6, 2025 22:42
paulovmr
suggested changes
Jan 7, 2025
added 2 commits
January 8, 2025 11:48
paulovmr
suggested changes
Jan 8, 2025
| @@ -21397,4 +21397,4 @@ | |||
| } | |||
| } | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
@senanz This change also needs to be reverted, otherwise the npm install will change it back as before locally for everyone.
| @@ -129,6 +134,8 @@ export const Workspaces: React.FunctionComponent = () => { | |||
| state: 'State', | |||
| homeVol: 'Home Vol', | |||
| dataVol: 'Data Vol', | |||
| cpu: 'cpu', | |||
There was a problem hiding this comment.
For the column name, it should be uppercase
Suggested change
| cpu: 'cpu', | |
| cpu: 'CPU', |
| @@ -129,6 +134,8 @@ export const Workspaces: React.FunctionComponent = () => { | |||
| state: 'State', | |||
| homeVol: 'Home Vol', | |||
| dataVol: 'Data Vol', | |||
| cpu: 'cpu', | |||
| ram: 'ram', | |||
There was a problem hiding this comment.
Suggested change
| ram: 'ram', | |
| ram: 'Memory', |
added 2 commits
January 8, 2025 16:30
paulovmr
approved these changes
Jan 8, 2025
ederign
approved these changes
Jan 8, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, paulovmr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new columns CPU and RAM that used by the workspace, fixes #151