Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): Add "Connect" column to workspace table and display popup with workspace endpoints. #161

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

Yael-F
Copy link

@Yael-F Yael-F commented Dec 17, 2024

Fixes #150
This PR adds a "Connect" column to the workspace table, positioned before the Actions column.
The new column displays a list of endpoints on hover.

I've added a screenshot of the implementation. Please let me know if any further changes are needed.
image

@Yael-F
Copy link
Author

Yael-F commented Jan 14, 2025

Following a discussion with @jenny-s51, we've decided to move the endpoints into the expanded table row.

The updated screenshot:
image

@thesuperzapper
Copy link
Member

@Yael-F The intention of this button is to connect to the notebook instance (open a new tab), making it the single most important button on the page, it must be in the main row.

The design I was thinking was a button with dropdown to select which port to connect to.

gAt78

NOTE: replace "Primary" with "Jupyter" (or whatever the first port is called), and the other actions being the other ports (or greyed out if there is only one).

NOTE 2: we might also want some kind of "connect" icon on the left side of the button, but I am not sure if that will just clutter.

@ederign
Copy link
Member

ederign commented Jan 15, 2025

@Yael-F I agree with @thesuperzapper! That is the primary action when I open the workspaces listing.

@Yael-F Yael-F force-pushed the add_connect_column branch 3 times, most recently from 09574e0 to a933edc Compare January 23, 2025 20:13
@Yael-F
Copy link
Author

Yael-F commented Jan 23, 2025

Hey @thesuperzapper
Moved the connect button to the main row, if you can take a look.

image

Jenn (the UX) suggested to label the dropdown with "Connect" (instead of the first endpoint) for better clarity, what do you say?

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Yael-F , thanks for the PR!
Please check the npm run test locally, it has a few errors. You can use npm run test:fix to fix most of them. Also please rebase your branch with the latest commits.

workspace: Workspace;
};

export const EndpointsDropdown: React.FunctionComponent<EndpointsDropdownProps> = ({workspace}) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider renaming the file and component (and other associated types, like the EndpointsDropdownProps) to WorkspaceConnectAction.

@Yael-F Yael-F force-pushed the add_connect_column branch from a36531d to 19f4e9a Compare February 4, 2025 14:08
@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Feb 4, 2025
@Yael-F Yael-F force-pushed the add_connect_column branch from 19f4e9a to 79a5f0c Compare February 4, 2025 15:55
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Feb 4, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 4, 2025
@google-oss-prow google-oss-prow bot merged commit 16f97f8 into kubeflow:notebooks-v2 Feb 4, 2025
3 checks passed
@Yael-F Yael-F deleted the add_connect_column branch February 11, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants