Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add how to install yarn via apt for Ubuntu users. #662

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fujitatomoya
Copy link
Contributor

@fujitatomoya fujitatomoya commented Jan 17, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Which issue(s) this PR fixes:

Fixes #571

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Quick guide for ubuntu user how to install yarn.

  • What is the current behavior? (You can also link to an open issue here)

Not mentioned, not friendly for ubuntu user to get started.

  • What is the new behavior (if this is a feature change)?

N.A

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

N.A

@kubeedge-bot kubeedge-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2025
Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my assumption here is that most likely developers would use ubuntu platform, this could be more developer friendly procedure to set up the doc dev environment.

Copy link
Collaborator

@Shelley-BaoYue Shelley-BaoYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Looks great! And I will update to the Chinese version according to this PR. Is it okay?

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@fujitatomoya
Copy link
Contributor Author

@Shelley-BaoYue

Looks great! And I will update to the Chinese version according to this PR. Is it okay?

yes, please.

before you do that, i will try to address @wbc6080 's comments.

@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2025
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shelley-baoyue after the PR has been reviewed.
You can assign the PR to them by writing /assign @shelley-baoyue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fujitatomoya
Copy link
Contributor Author

@wbc6080 i use ubuntu, and confirmed both procedure works without any problems.

@wbc6080
Copy link
Contributor

wbc6080 commented Jan 20, 2025

@wbc6080 i use ubuntu, and confirmed both procedure works without any problems.

OK, thanks for your contribution!
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn: ERROR: There are no scenarios; must have at least one.
4 participants