Support adding dependencies to an existing Ktor project #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shells Use group/name and module attributes based on existing Ktor dependencies Small fixes Accept variable number of modules to add Allow adding client dependencies and refactoring Extract into function getting the TOML catalog path Refactor checking if dependency is already exist Add a Ktor dependency to a list where versions stored in Kotlin variables Check if Ktor dep with version variable does already exist Consider platform suffixes of other Ktor dependencies Use the same variable reference for the dependency if any dependencies have version got by a delegate Print messages about not supported Maven and Groovy DSL projects Print a message that adding dependency to a KMP project isn't supported Print info messages when configuration isn't supported for adding a Ktor dependency Print friendly message to file a bug on panicking Add prompt to ask if changes should be applied to apply the changes Add a case when no dependencies in build and no libraries in toml Look for serialization plugin with full ID Add Ktor dependency with a proper suffix taken from other Ktor dependencies Add raw Ktor test dependency Add raw Ktor dependency when Ktor Gradle plugin is defined Fix parsing Gradle files without a new line at EOF Check if serialization plugin is already defined Add serialization plugin when a dependency requires it Refactor TOML parsing Refactor Kotlin parsing WIP Add a Ktor dependency when no other dependencies and no catalog file Check if a hardcoded dependency is present with BOM Fix the BOM test and distinguish Ktor shared dependencies Add dependency for case when BOM is present Check if the given Ktor dependency is already defined Add a case when no Ktor versions in the toml file Add a case when versions file doesn't contain any Ktor dependencies Add shared dependencies and improve finding by edit distance Test adding dependencies and add a simple scenario Use MavenCoords struct KTOR-7749 Find Ktor maven coordinates by module name or an associated symbol KTOR-7749 Add basic implementation for adding a Ktor dependency into version catalog
…module and for completions respectively
…at syntax errors as fatal ones.
|
Could you add a few screenshots here? I'm curious to see what the diff looks like etc. |
vnikolova
reviewed
Feb 3, 2025
bjhham
approved these changes
Feb 4, 2025
vnikolova
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTOR-7749
The PR seems huge, but it's not. Most of the files are generated by ANTLR or are part of the test projects.
This PR adds the
addcommand, which can be used to add Ktor dependencies to a Gradle project.The usage instructions can be found in the README.md.
How it works
build.gradle.ktsand version catalog files./project/settingsendpoint.artifacts/{version}/searchendpoint to search for the Ktor artifacts by a given name.build.gradle.ktsand the version catalog files (if it exists).