Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for macOS version 12 #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

apizz
Copy link

@apizz apizz commented Apr 26, 2017

Since the AssetCacheLocatorUtil binary is part of macOS Sierra, add check to ensure machines running versions less than 12 don't attempt to run the command.

Copy link
Contributor

@bmike bmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change rather than failing. Tests well on 10.12 and 10.13 but fails on 10.9 and lower since "9" isn't < "12"

Perhaps change line 11 to use -lt operator instead of <

@bmike
Copy link
Contributor

bmike commented Feb 21, 2018

To be clear - I'd still merge this change. It fails less often in 10.10 through 10.13 and still fails the same with the same error as the original script for 10.9 and older OS.

@apizz
Copy link
Author

apizz commented Jan 8, 2021

wew this is old ... maybe it's time she merges :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants