Modernization: Replace Deprecated each() Function in tln_tagprint
#1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Description
Updated `tln_tagprint` method to use modern PHP iteration syntax, removing deprecated `each()` function.
#### Details
- Replaced `each()` with `foreach` loop
- Simplified array population method
- Maintained original method logic
- Ensures compatibility with PHP 7.2+ and PHP 8.0+
#### Code Change
```php
// Before
while ([$attname, $attvalue] = each($attary)) {
array_push($atts, "$attname=$attvalue");
}
// After
foreach ($attary as $attname => $attvalue) {
$atts[] = "$attname=$attvalue";
}
```
### Rationale
- #each() function is deprecated and removed in newer PHP versions
- #foreach provides a more modern and readable way to iterate arrays
- #$atts[] is a more concise way to add elements to an array compared to #array_push()
- Improves code maintainability and compatibility
amit-webkul
previously approved these changes
Dec 31, 2024
Restore the original array construction format while replacing deprecated each() function: - Maintain array_push() instead of using array[] syntax - Keep the exact same string format for attributes - Ensure compatibility with PHP 8.2 and 8.3
GabrielBragaGit
commented
Dec 31, 2024
amit-webkul
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated
tln_tagprintmethod to use modern PHP iteration syntax, removing deprecatedeach()function.Details
each()withforeachloopCode Change
Rationale
each()function is deprecated and removed in newer PHP versionsforeachprovides a more modern and readable way to iterate arrays$atts[]is a more concise way to add elements to an array compared toarray_push()