Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernization: Replace Deprecated each() Function #1910

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Modernization: Replace Deprecated each() Function #1910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/Webkul/Email/src/Helpers/Htmlfilter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,12 @@ public function tln_fixatts(
$trans_image_path,
$block_external_images
) {
while ([$attname, $attvalue] = each($attary)) {
/**
* Convert to array if is not
*/
$attary = is_array($attary) ? $attary : [];

foreach ($attary as $attname => $attvalue) {
Comment on lines +563 to +568
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabrielBragaGit ,

Please run the command to fix the failing Pint test cases and then push the updated code.

vendor/bin/pint

/**
* See if this attribute should be removed.
*/
Expand All @@ -570,7 +575,7 @@ public function tln_fixatts(
if (preg_match($matchattr, $attname)) {
unset($attary[$attname]);

continue;
continue 2;
}
}
}
Expand Down
Loading