Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Get Started section #624

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

dalg24
Copy link
Member

@dalg24 dalg24 commented Feb 1, 2025

Users should be able to get their first program up and running after reading this section.

Users should be able to get their first program up and running after
reading this section.
Copy link
Contributor

@JBludau JBludau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the suggestions are def. non-blocking


> mkdir MyProject && cd MyProject

Next, you’ll create the ``CMakeLists.txt`` file and declare a dependency on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe redundant with the line 48


* a compatible operating system (e.g. Linux, macOS, Windows).
* a compatible C++ compiler that supports at least C++17.
* `CMake <https://cmake.org/>`_ and a compatible build tool for building the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe spell out the minimum version here? we probably require one implicitly ... but might be outside of the scope here

@crtrott crtrott merged commit 733285e into kokkos:main Feb 3, 2025
2 checks passed
@dalg24 dalg24 deleted the improve_quickstart_guide branch February 4, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants