Remove old build notes for cmake <3.12 #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalg24
reviewed
Jan 27, 2025
Comment on lines
-28
to
-31
| Note: You may need the following if using some versions of CMake (e.g. 3.12): | ||
| ````cmake | ||
| cmake_policy(SET CMP0074 NEW) | ||
| ```` |
There was a problem hiding this comment.
Note: Using Kokkos_ROOT requires CMP0074 to be set to NEW, e.g., using
cmake_policy(SET CMP0074 NEW)when the minimum required CMake version in the dowsntream project is less than 3.12.
|
Not sure if we really test this, but I will close this for now. If we update our cmake build system we will need to revisit this because there we impose 3.21 on downstream projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we require 3.16 users should not hit this